Commit 66f669a2 authored by Stefan Haberland's avatar Stefan Haberland Committed by Jens Axboe
Browse files

s390/dasd: fix hanging IO request during DASD driver unbind 



Prevent that an IO request is build during device shutdown initiated by
a driver unbind. This request will never be able to be processed or
canceled and will hang forever. This will lead also to a hanging unbind.

Fix by checking not only if the device is in READY state but also check
that there is no device offline initiated before building a new IO request.

Fixes: e443343e ("s390/dasd: blk-mq conversion")

Cc: <stable@vger.kernel.org> # v4.14+
Signed-off-by: default avatarStefan Haberland <sth@linux.ibm.com>
Tested-by: default avatarBjoern Walk <bwalk@linux.ibm.com>
Reviewed-by: default avatarJan Hoeppner <hoeppner@linux.ibm.com>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 7d365bd0

drivers/s390/block/dasd.c

+2 −1
Original line number Diff line number Diff line
@@ -3052,7 +3052,8 @@ static blk_status_t do_dasd_request(struct blk_mq_hw_ctx *hctx, 


	basedev = block->base;

	spin_lock_irq(&dq->lock);

	if (basedev->state < DASD_STATE_READY) {

	if (basedev->state < DASD_STATE_READY ||

	    test_bit(DASD_FLAG_OFFLINE, &basedev->flags)) {

		DBF_DEV_EVENT(DBF_ERR, basedev,

			      "device not ready for request %p", req);

		rc = BLK_STS_IOERR;