Unverified Commit 66efb665 authored by Liang He's avatar Liang He Committed by Mark Brown
Browse files

regulator: of: Fix refcount leak bug in of_get_regulation_constraints() 



We should call the of_node_put() for the reference returned by
of_get_child_by_name() which has increased the refcount.

Fixes: 40e20d68 ("regulator: of: Add support for parsing regulator_state for suspend state")
Signed-off-by: default avatarLiang He <windhl@126.com>
Link: https://lore.kernel.org/r/20220715111027.391032-1-windhl@126.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 91de5eb1

drivers/regulator/of_regulator.c

+5 −1
Original line number Diff line number Diff line
@@ -264,8 +264,12 @@ static int of_get_regulation_constraints(struct device *dev, 
		}



		suspend_np = of_get_child_by_name(np, regulator_states[i]);

		if (!suspend_np || !suspend_state)

		if (!suspend_np)

			continue;

		if (!suspend_state) {

			of_node_put(suspend_np);

			continue;

		}



		if (!of_property_read_u32(suspend_np, "regulator-mode",

					  &pval)) {