Commit 66e4c8d9 authored by Eric Dumazet's avatar Eric Dumazet Committed by David S. Miller
Browse files

net: warn if transport header was not set 



Make sure skb_transport_header() and skb_transport_offset() uses
are not fooled if the transport header has not been set.

This change will likely expose existing bugs in linux networking stacks.

Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent d268c1f5

include/linux/skbuff.h

+2 −0
Original line number Original line Diff line number Diff line
@@ -42,6 +42,7 @@ 
#if IS_ENABLED(CONFIG_NF_CONNTRACK)

#if IS_ENABLED(CONFIG_NF_CONNTRACK)

#include <linux/netfilter/nf_conntrack_common.h>

#include <linux/netfilter/nf_conntrack_common.h>

#endif

#endif

#include <net/net_debug.h>





/**

/**

 * DOC: skb checksums

 * DOC: skb checksums
@@ -2904,6 +2905,7 @@ static inline bool skb_transport_header_was_set(const struct sk_buff *skb) 




static inline unsigned char *skb_transport_header(const struct sk_buff *skb)

static inline unsigned char *skb_transport_header(const struct sk_buff *skb)

{

{

	DEBUG_NET_WARN_ON_ONCE(!skb_transport_header_was_set(skb));

	return skb->head + skb->transport_header;

	return skb->head + skb->transport_header;

}

}