Commit 66cb3a2d authored by David Arcari's avatar David Arcari Committed by Hans de Goede
Browse files

platform/x86/intel: Fix pmt_crashlog array reference 



The probe function pmt_crashlog_probe() may incorrectly reference
the 'priv->entry array' as it uses 'i' to reference the array instead
of 'priv->num_entries' as it should.  This is similar to the problem
that was addressed in pmt_telemetry_probe via commit 2cdfa0c2
("platform/x86/intel: Fix 'rmmod pmt_telemetry' panic").

Cc: "David E. Box" <david.e.box@linux.intel.com>
Cc: Hans de Goede <hdegoede@redhat.com>
Cc: Mark Gross <markgross@kernel.org>
Cc: linux-kernel@vger.kernel.org
Signed-off-by: default avatarDavid Arcari <darcari@redhat.com>
Reviewed-by: default avatarDavid E. Box <david.e.box@linux.intel.com>
Link: https://lore.kernel.org/r/20220526203140.339120-1-darcari@redhat.com


Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
parent b9c29f39

drivers/platform/x86/intel/pmt/crashlog.c

+1 −1
Original line number Diff line number Diff line
@@ -282,7 +282,7 @@ static int pmt_crashlog_probe(struct auxiliary_device *auxdev, 
	auxiliary_set_drvdata(auxdev, priv);



	for (i = 0; i < intel_vsec_dev->num_resources; i++) {

		struct intel_pmt_entry *entry = &priv->entry[i].entry;

		struct intel_pmt_entry *entry = &priv->entry[priv->num_entries].entry;



		ret = intel_pmt_dev_create(entry, &pmt_crashlog_ns, intel_vsec_dev, i);

		if (ret < 0)