Unverified Commit 66a22159 authored by David Jander's avatar David Jander Committed by Mark Brown
Browse files

spi: Remove the now unused ctlr->idling flag 



The ctlr->idling flag is never checked now, so we don't need to set it
either.

Signed-off-by: default avatarDavid Jander <david@protonic.nl>
Link: https://lore.kernel.org/r/20220621061234.3626638-8-david@protonic.nl


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 049d6ccc

drivers/spi/spi.c

+0 −2
Original line number Diff line number Diff line
@@ -1674,7 +1674,6 @@ static void __spi_pump_messages(struct spi_controller *ctlr, bool in_kthread) 
		}



		ctlr->busy = false;

		ctlr->idling = true;

		spin_unlock_irqrestore(&ctlr->queue_lock, flags);



		kfree(ctlr->dummy_rx);
@@ -1689,7 +1688,6 @@ static void __spi_pump_messages(struct spi_controller *ctlr, bool in_kthread) 
		trace_spi_controller_idle(ctlr);



		spin_lock_irqsave(&ctlr->queue_lock, flags);

		ctlr->idling = false;

		ctlr->queue_empty = true;

		goto out_unlock;

	}

include/linux/spi/spi.h

+0 −2
Original line number Diff line number Diff line
@@ -383,7 +383,6 @@ extern struct spi_device *spi_new_ancillary_device(struct spi_device *spi, u8 ch 
 * @pump_messages: work struct for scheduling work to the message pump

 * @queue_lock: spinlock to syncronise access to message queue

 * @queue: message queue

 * @idling: the device is entering idle state

 * @cur_msg: the currently in-flight message

 * @cur_msg_mapped: message has been mapped for DMA

 * @last_cs: the last chip_select that is recorded by set_cs, -1 on non chip
@@ -616,7 +615,6 @@ struct spi_controller { 
	spinlock_t			queue_lock;

	struct list_head		queue;

	struct spi_message		*cur_msg;

	bool				idling;

	bool				busy;

	bool				running;

	bool				rt;