Commit 669a0646 authored by Lukas Bulwahn's avatar Lukas Bulwahn Committed by Jens Axboe
Browse files

block: drop needless assignment in set_task_ioprio() 



Commit 5fc11eeb ("block: open code create_task_io_context in
set_task_ioprio") introduces a needless assignment
'ioc = task->io_context', as the local variable ioc is not further
used before returning.

Even after the further fix, commit a957b612 ("block: fix error in
handling dead task for ioprio setting"), the assignment still remains
needless.

Drop this needless assignment in set_task_ioprio().

This code smell was identified with 'make clang-analyzer'.

Fixes: 5fc11eeb ("block: open code create_task_io_context in set_task_ioprio")
Signed-off-by: default avatarLukas Bulwahn <lukas.bulwahn@gmail.com>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Link: https://lore.kernel.org/r/20211223125300.20691-1-lukas.bulwahn@gmail.com


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent a16c7246

block/blk-ioc.c

+2 −4
Original line number Diff line number Diff line
@@ -284,13 +284,11 @@ int set_task_ioprio(struct task_struct *task, int ioprio) 
			kmem_cache_free(iocontext_cachep, ioc);

			goto out;

		}

		if (task->io_context) {

		if (task->io_context)

			kmem_cache_free(iocontext_cachep, ioc);

			ioc = task->io_context;

		} else {

		else

			task->io_context = ioc;

	}

	}

	task->io_context->ioprio = ioprio;

out:

	task_unlock(task);