Commit 6622f9ac authored by Hannes Reinecke's avatar Hannes Reinecke Committed by Christoph Hellwig
Browse files

nvme-loop: do not warn for deleted controllers during reset 



During concurrent reset and delete calls the reset workqueue is
flushed, causing nvme_loop_reset_ctrl_work() to be executed when
the controller is in state DELETING or DELETING_NOIO.
But this is expected, so we shouldn't issue a WARN_ON here.

Signed-off-by: default avatarHannes Reinecke <hare@suse.de>
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
parent 4237de2f

drivers/nvme/target/loop.c

+4 −2
Original line number Diff line number Diff line
@@ -465,7 +465,9 @@ static void nvme_loop_reset_ctrl_work(struct work_struct *work) 
	nvme_loop_shutdown_ctrl(ctrl);



	if (!nvme_change_ctrl_state(&ctrl->ctrl, NVME_CTRL_CONNECTING)) {

		/* state change failure should never happen */

		if (ctrl->ctrl.state != NVME_CTRL_DELETING &&

		    ctrl->ctrl.state != NVME_CTRL_DELETING_NOIO)

			/* state change failure for non-deleted ctrl? */

			WARN_ON_ONCE(1);

		return;

	}