Commit 6601fc0d authored by Dean Luick's avatar Dean Luick Committed by Leon Romanovsky
Browse files

IB/hfi1: Restore allocated resources on failed copyout 



Fix a resource leak if an error occurs.

Fixes: f404ca4c ("IB/hfi1: Refactor hfi_user_exp_rcv_setup() IOCTL")
Signed-off-by: default avatarDean Luick <dean.luick@cornelisnetworks.com>
Signed-off-by: default avatarDennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
Link: https://lore.kernel.org/r/167354736291.2132367.10894218740150168180.stgit@awfm-02.cornelisnetworks.com


Signed-off-by: default avatarLeon Romanovsky <leon@kernel.org>
parent 0f097f08

drivers/infiniband/hw/hfi1/file_ops.c

+5 −2
Original line number Original line Diff line number Diff line
@@ -1318,12 +1318,15 @@ static int user_exp_rcv_setup(struct hfi1_filedata *fd, unsigned long arg, 
		addr = arg + offsetof(struct hfi1_tid_info, tidcnt);

		addr = arg + offsetof(struct hfi1_tid_info, tidcnt);

		if (copy_to_user((void __user *)addr, &tinfo.tidcnt,

		if (copy_to_user((void __user *)addr, &tinfo.tidcnt,

				 sizeof(tinfo.tidcnt)))

				 sizeof(tinfo.tidcnt)))

			return -EFAULT;

			ret = -EFAULT;





		addr = arg + offsetof(struct hfi1_tid_info, length);

		addr = arg + offsetof(struct hfi1_tid_info, length);

		if (copy_to_user((void __user *)addr, &tinfo.length,

		if (!ret && copy_to_user((void __user *)addr, &tinfo.length,

				 sizeof(tinfo.length)))

				 sizeof(tinfo.length)))

			ret = -EFAULT;

			ret = -EFAULT;



		if (ret)

			hfi1_user_exp_rcv_invalid(fd, &tinfo);

	}

	}





	return ret;

	return ret;