Commit 65e9d2fa authored by Michał Mirosław's avatar Michał Mirosław Committed by David S. Miller
Browse files

net: fix NULL-deref in WARN() in skb_gso_segment() 



Bug was introduced in commit c8f44aff.

Signed-off-by: default avatarMichał Mirosław <mirq-linux@rere.qmqm.pl>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 36c92474

net/core/dev.c

+3 −2
Original line number Diff line number Diff line
@@ -1889,6 +1889,7 @@ EXPORT_SYMBOL(skb_set_dev); 


static void skb_warn_bad_offload(const struct sk_buff *skb)

{

	static const netdev_features_t null_features = 0;

	struct net_device *dev = skb->dev;

	const char *driver = "";
@@ -1897,8 +1898,8 @@ static void skb_warn_bad_offload(const struct sk_buff *skb) 


	WARN(1, "%s: caps=(%pNF, %pNF) len=%d data_len=%d gso_size=%d "

	     "gso_type=%d ip_summed=%d\n",

	     driver, dev ? &dev->features : NULL,

	     skb->sk ? &skb->sk->sk_route_caps : NULL,

	     driver, dev ? &dev->features : &null_features,

	     skb->sk ? &skb->sk->sk_route_caps : &null_features,

	     skb->len, skb->data_len, skb_shinfo(skb)->gso_size,

	     skb_shinfo(skb)->gso_type, skb->ip_summed);

}