Commit 65e5d27d authored by Jianglei Nie's avatar Jianglei Nie Committed by David S. Miller
Browse files

net: atlantic: fix potential memory leak in aq_ndev_close() 



If aq_nic_stop() fails, aq_ndev_close() returns err without calling
aq_nic_deinit() to release the relevant memory and resource, which
will lead to a memory leak.

We can fix it by deleting the if condition judgment and goto statement to
call aq_nic_deinit() directly after aq_nic_stop() to fix the memory leak.

Signed-off-by: default avatarJianglei Nie <niejianglei2021@163.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 79a392a3

drivers/net/ethernet/aquantia/atlantic/aq_main.c

+0 −3
Original line number Diff line number Diff line
@@ -94,11 +94,8 @@ static int aq_ndev_close(struct net_device *ndev) 
	int err = 0;



	err = aq_nic_stop(aq_nic);

	if (err < 0)

		goto err_exit;

	aq_nic_deinit(aq_nic, true);



err_exit:

	return err;

}