Commit 65cdf0d6 authored by Kees Cook's avatar Kees Cook Committed by Peter Zijlstra
Browse files

x86/alternative: Report missing return thunk details 



Debugging missing return thunks is easier if we can see where they're
happening.

Suggested-by: default avatarPeter Zijlstra <peterz@infradead.org>
Signed-off-by: default avatarKees Cook <keescook@chromium.org>
Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lore.kernel.org/lkml/Ys66hwtFcGbYmoiZ@hirez.programming.kicks-ass.net/
parent 908fc4c2

arch/x86/kernel/alternative.c

+3 −1
Original line number Diff line number Diff line
@@ -555,7 +555,9 @@ void __init_or_module noinline apply_returns(s32 *start, s32 *end) 
			dest = addr + insn.length + insn.immediate.value;



		if (__static_call_fixup(addr, op, dest) ||

		    WARN_ON_ONCE(dest != &__x86_return_thunk))

		    WARN_ONCE(dest != &__x86_return_thunk,

			      "missing return thunk: %pS-%pS: %*ph",

			      addr, dest, 5, addr))

			continue;



		DPRINTK("return thunk at: %pS (%px) len: %d to: %pS",