Commit 65a45441 authored by Stephen Hemminger's avatar Stephen Hemminger Committed by David S. Miller
Browse files

[UDP]: udp_checksum_init return value 



Since udp_checksum_init always returns 0 there is no point in
having it return a value.

Signed-off-by: default avatarStephen Hemminger <shemminger@osdl.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 3305b80c

net/ipv4/udp.c

+2 −4
Original line number Diff line number Diff line
@@ -1081,7 +1081,7 @@ static int udp_v4_mcast_deliver(struct sk_buff *skb, struct udphdr *uh, 
 * Otherwise, csum completion requires chacksumming packet body,

 * including udp header and folding it to skb->csum.

 */

static int udp_checksum_init(struct sk_buff *skb, struct udphdr *uh,

static void udp_checksum_init(struct sk_buff *skb, struct udphdr *uh,

			     unsigned short ulen, u32 saddr, u32 daddr)

{

	if (uh->check == 0) {
@@ -1095,7 +1095,6 @@ static int udp_checksum_init(struct sk_buff *skb, struct udphdr *uh, 
	/* Probably, we should checksum udp header (it should be in cache

	 * in any case) and data in tiny packets (< rx copybreak).

	 */

	return 0;

}



/*
@@ -1128,8 +1127,7 @@ int udp_rcv(struct sk_buff *skb) 
	if (pskb_trim_rcsum(skb, ulen))

		goto short_packet;



	if (udp_checksum_init(skb, uh, ulen, saddr, daddr) < 0)

		goto csum_error;

	udp_checksum_init(skb, uh, ulen, saddr, daddr);



	if(rt->rt_flags & (RTCF_BROADCAST|RTCF_MULTICAST))

		return udp_v4_mcast_deliver(skb, uh, saddr, daddr);