Commit 65a1c4ff authored Oct 23, 2009 by roel kluin Committed by David S. Miller Oct 29, 2009

net: Cleanup redundant tests on unsigned



optlen is unsigned so the `< 0' test is never true.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 091bb8ab

net/can/raw.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -424,8 +424,6 @@ static int raw_setsockopt(struct socket *sock, int level, int optname,

		if (level != SOL_CAN_RAW)
		return -EINVAL;
		if (optlen < 0)
		return -EINVAL;

		switch (optname) {

net/compat.c

+0 −3

Original line number	Diff line number	Diff line
		@@ -390,9 +390,6 @@ asmlinkage long compat_sys_setsockopt(int fd, int level, int optname,
		int err;
		struct socket *sock;

		if (optlen < 0)
		return -EINVAL;

		if ((sock = sockfd_lookup(fd, &err))!=NULL)
		{
		err = security_socket_setsockopt(sock,level,optname);

net/ipv4/ip_sockglue.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -480,7 +480,7 @@ static int do_ip_setsockopt(struct sock *sk, int level,
		case IP_OPTIONS:
		{
		struct ip_options *opt = NULL;
		if (optlen > 40 \|\| optlen < 0)
		if (optlen > 40)
		goto e_inval;
		err = ip_options_get_from_user(sock_net(sk), &opt,
		optval, optlen);