Commit 65966aac authored by Sean Christopherson's avatar Sean Christopherson
Browse files

KVM: x86: Assert that the emulator doesn't load CS with garbage in !RM 



Yell loudly if KVM attempts to load CS outside of Real Mode without an
accompanying control transfer type, i.e. on X86_TRANSFER_NONE.  KVM uses
X86_TRANSFER_NONE when emulating IRET and exceptions/interrupts for Real
Mode, but IRET emulation for Protected Mode is non-existent.  WARN instead
of trying to pass in a less-wrong type, e.g. X86_TRANSFER_RET, as
emulating IRET goes even beyond emulating FAR RET (which KVM also doesn't
fully support).

Reported-by: default avatarHou Wenlong <houwenlong.hwl@antgroup.com>
Link: https://lore.kernel.org/r/20230216202254.671772-1-seanjc@google.com


Signed-off-by: default avatarSean Christopherson <seanjc@google.com>
parent 3d8f61bf

arch/x86/kvm/emulate.c

+8 −0
Original line number Diff line number Diff line
@@ -1640,6 +1640,14 @@ static int __load_segment_descriptor(struct x86_emulate_ctxt *ctxt, 
			goto exception;

		break;

	case VCPU_SREG_CS:

		/*

		 * KVM uses "none" when loading CS as part of emulating Real

		 * Mode exceptions and IRET (handled above).  In all other

		 * cases, loading CS without a control transfer is a KVM bug.

		 */

		if (WARN_ON_ONCE(transfer == X86_TRANSFER_NONE))

			goto exception;



		if (!(seg_desc.type & 8))

			goto exception;