Commit 658924dc authored by Eric Dumazet's avatar Eric Dumazet Committed by David S. Miller
Browse files

hp100: fix an skb->len race 



As soon as skb is given to hardware and spinlock released, TX completion
can free skb under us. Therefore, we should update netdev stats before
spinlock release.

Signed-off-by: default avatarEric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 00ce2d56

drivers/net/hp100.c

+2 −2
Original line number Diff line number Diff line
@@ -1580,12 +1580,12 @@ static netdev_tx_t hp100_start_xmit_bm(struct sk_buff *skb, 
	hp100_outl(ringptr->pdl_paddr, TX_PDA_L);	/* Low Prio. Queue */



	lp->txrcommit++;

	spin_unlock_irqrestore(&lp->lock, flags);



	/* Update statistics */

	dev->stats.tx_packets++;

	dev->stats.tx_bytes += skb->len;



	spin_unlock_irqrestore(&lp->lock, flags);



	return NETDEV_TX_OK;



drop: