Commit 6570d1d4 authored by Johan Hovold's avatar Johan Hovold Committed by Georgi Djakov
Browse files

interconnect: qcom: rpmh: fix probe child-node error handling 



Make sure to clean up and release resources properly also in case probe
fails when populating child devices.

Fixes: 57eb1477 ("interconnect: qcom: icc-rpmh: Support child NoC device probe")
Cc: stable@vger.kernel.org      # 6.0
Cc: Luca Weiss <luca.weiss@fairphone.com>
Reviewed-by: default avatarKonrad Dybcio <konrad.dybcio@linaro.org>
Signed-off-by: default avatarJohan Hovold <johan+linaro@kernel.org>
Link: https://lore.kernel.org/r/20230306075651.2449-10-johan+linaro@kernel.org


Signed-off-by: default avatarGeorgi Djakov <djakov@kernel.org>
parent 90ae93d8

drivers/interconnect/qcom/icc-rpmh.c

+5 −2
Original line number Diff line number Diff line
@@ -235,8 +235,11 @@ int qcom_icc_rpmh_probe(struct platform_device *pdev) 
	platform_set_drvdata(pdev, qp);



	/* Populate child NoC devices if any */

	if (of_get_child_count(dev->of_node) > 0)

		return of_platform_populate(dev->of_node, NULL, NULL, dev);

	if (of_get_child_count(dev->of_node) > 0) {

		ret = of_platform_populate(dev->of_node, NULL, NULL, dev);

		if (ret)

			goto err;

	}



	return 0;

err: