Commit 6558b646 authored by Jamie Iles's avatar Jamie Iles Committed by Wolfram Sang
Browse files

i2c: acpi: fix resource leak in reconfiguration device addition 



acpi_i2c_find_adapter_by_handle() calls bus_find_device() which takes a
reference on the adapter which is never released which will result in a
reference count leak and render the adapter unremovable.  Make sure to
put the adapter after creating the client in the same manner that we do
for OF.

Fixes: 525e6fab ("i2c / ACPI: add support for ACPI reconfigure notifications")
Signed-off-by: default avatarJamie Iles <quic_jiles@quicinc.com>
Acked-by: default avatarMika Westerberg <mika.westerberg@linux.intel.com>
[wsa: fixed title]
Signed-off-by: default avatarWolfram Sang <wsa@kernel.org>
parent 5816b3e6

drivers/i2c/i2c-core-acpi.c

+1 −0
Original line number Diff line number Diff line
@@ -454,6 +454,7 @@ static int i2c_acpi_notify(struct notifier_block *nb, unsigned long value, 
			break;



		i2c_acpi_register_device(adapter, adev, &info);

		put_device(&adapter->dev);

		break;

	case ACPI_RECONFIG_DEVICE_REMOVE:

		if (!acpi_device_enumerated(adev))