Commit 6553fc18 authored by Vincent Guittot's avatar Vincent Guittot Committed by Ingo Molnar
Browse files

sched/fair: Reorder newidle_balance pulled_task tests 



Reorder the tests and skip useless ones when no load balance has been
performed and rq lock has not been released.

Signed-off-by: default avatarVincent Guittot <vincent.guittot@linaro.org>
Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
Reviewed-by: default avatarValentin Schneider <valentin.schneider@arm.com>
Link: https://lkml.kernel.org/r/20210224133007.28644-6-vincent.guittot@linaro.org
parent 7a82e5f5

kernel/sched/fair.c

+5 −5
Original line number Diff line number Diff line
@@ -10584,7 +10584,6 @@ static int newidle_balance(struct rq *this_rq, struct rq_flags *rf) 
	if (curr_cost > this_rq->max_idle_balance_cost)

		this_rq->max_idle_balance_cost = curr_cost;



out:

	/*

	 * While browsing the domains, we released the rq lock, a task could

	 * have been enqueued in the meantime. Since we're not going idle,
@@ -10593,14 +10592,15 @@ static int newidle_balance(struct rq *this_rq, struct rq_flags *rf) 
	if (this_rq->cfs.h_nr_running && !pulled_task)

		pulled_task = 1;



	/* Move the next balance forward */

	if (time_after(this_rq->next_balance, next_balance))

		this_rq->next_balance = next_balance;



	/* Is there a task of a high priority class? */

	if (this_rq->nr_running != this_rq->cfs.h_nr_running)

		pulled_task = -1;



out:

	/* Move the next balance forward */

	if (time_after(this_rq->next_balance, next_balance))

		this_rq->next_balance = next_balance;



	if (pulled_task)

		this_rq->idle_stamp = 0;

	else