Commit 652de07a authored by Roman Li's avatar Roman Li Committed by Alex Deucher
Browse files

drm/amd/display: Fully switch to dmub for all dcn21 asics 

[Why]
On renoir usb-c port stops functioning on resume after f/w update.
New dmub firmware caused regression due to conflict with dmcu.
With new dmub f/w dmcu is superseded and should be disabled.

[How]
- Disable dmcu for all dcn21.

Check dmesg for dmub f/w version.
The old firmware (before regression):
[drm] DMUB hardware initialized: version=0x00000001
All other versions require this patch for renoir.

Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/1735


Acked-by: default avatarAlex Deucher <alexander.deucher@amd.com>
Reviewed-by: default avatarHarry Wentland <harry.wentland@amd.com>
Tested-by: default avatarMario Limonciello <mario.limonciello@amd.com>
Signed-off-by: default avatarRoman Li <Roman.Li@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent a3848df6

drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c

+1 −2
Original line number Diff line number Diff line
@@ -1356,7 +1356,6 @@ static int amdgpu_dm_init(struct amdgpu_device *adev) 
		switch (adev->ip_versions[DCE_HWIP][0]) {

		case IP_VERSION(2, 1, 0):

			init_data.flags.gpu_vm_support = true;

			if (ASICREV_IS_GREEN_SARDINE(adev->external_rev_id))

			init_data.flags.disable_dmcu = true;

			break;

		case IP_VERSION(1, 0, 0):