Commit 64f879be authored by John Garry's avatar John Garry Committed by Zhou Juan
Browse files

scsi: libsas: Update SATA dev FIS in sas_ata_task_done() 

mainline inclusion
from mainline-v6.2-rc1
commit cc22efbe
category: bugfix
bugzilla: https://gitee.com/openeuler/kernel/issues/I6NPLN
CVE: NA

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=cc22efbec0110181725b1f5f6778155a2e352522



----------------------------------------------------------------------

In sas_ata_task_done(), for commands which complete with error we set the
SATA dev FIS status field with ATA_ERR. In ata_eh_analyze_tf() this would
be interpreted as a HSM error. Set ATA_DRDY, which will lead libata to
judge as a device error, which is a safer bet.

Signed-off-by: default avatarJohn Garry <john.garry@huawei.com>
Link: https://lore.kernel.org/r/1665998435-199946-9-git-send-email-john.garry@huawei.com


Reviewed-by: default avatarNiklas Cassel <niklas.cassel@wdc.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: default avatarxiabing <xiabing12@h-partners.com>
parent 03c08d97

drivers/scsi/libsas/sas_ata.c

+2 −2
Original line number Diff line number Diff line
@@ -147,8 +147,8 @@ static void sas_ata_task_done(struct sas_task *task) 
				qc->flags |= ATA_QCFLAG_FAILED;

			}



			dev->sata_dev.fis[3] = 0x04; /* status err */

			dev->sata_dev.fis[2] = ATA_ERR;

			dev->sata_dev.fis[2] = ATA_ERR | ATA_DRDY; /* tf status */

			dev->sata_dev.fis[3] = ATA_ABORTED; /* tf error */

		}

	}