Commit 64cb6aad authored by Vladimir Oltean's avatar Vladimir Oltean Committed by Paolo Abeni
Browse files

net/sched: taprio: dynamic max_sdu larger than the max_mtu is unlimited 



It makes no sense to keep randomly large max_sdu values, especially if
larger than the device's max_mtu. These are visible in "tc qdisc show".
Such a max_sdu is practically unlimited and will cause no packets for
that traffic class to be dropped on enqueue.

Just set max_sdu_dynamic to U32_MAX, which in the logic below causes
taprio to save a max_frm_len of U32_MAX and a max_sdu presented to user
space of 0 (unlimited).

Signed-off-by: default avatarVladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: default avatarKurt Kanzenbach <kurt@linutronix.de>
Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent bdf366bd

net/sched/sch_taprio.c

+2 −0
Original line number Diff line number Diff line
@@ -288,6 +288,8 @@ static void taprio_update_queue_max_sdu(struct taprio_sched *q, 
						    dev->hard_header_len + 1);

			}

			max_sdu_dynamic = max_frm_len - dev->hard_header_len;

			if (max_sdu_dynamic > dev->max_mtu)

				max_sdu_dynamic = U32_MAX;

		}



		max_sdu = min(max_sdu_dynamic, max_sdu_from_user);