Unverified Commit 649fee5a authored by Chen-Yu Tsai's avatar Chen-Yu Tsai Committed by Mark Brown
Browse files

regulator: mt6358: Sync VCN33_* enable status after checking ID 



Syncing VCN33_* enable status should be done after checking the PMIC's
ID, to avoid setting random bits on other PMICs.

Suggested-by: default avatarAngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Fixes: 65bae54e ("regulator: mt6358: Merge VCN33_* regulators")
Signed-off-by: default avatarChen-Yu Tsai <wenst@chromium.org>
Reviewed-by: default avatarAngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Link: https://lore.kernel.org/r/20230721082903.2038975-3-wenst@chromium.org


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 6eaae198

drivers/regulator/mt6358-regulator.c

+4 −4
Original line number Diff line number Diff line
@@ -676,10 +676,6 @@ static int mt6358_regulator_probe(struct platform_device *pdev) 
	const struct mt6358_regulator_info *mt6358_info;

	int i, max_regulator, ret;



	ret = mt6358_sync_vcn33_setting(&pdev->dev);

	if (ret)

		return ret;



	if (mt6397->chip_id == MT6366_CHIP_ID) {

		max_regulator = MT6366_MAX_REGULATOR;

		mt6358_info = mt6366_regulators;
@@ -688,6 +684,10 @@ static int mt6358_regulator_probe(struct platform_device *pdev) 
		mt6358_info = mt6358_regulators;

	}



	ret = mt6358_sync_vcn33_setting(&pdev->dev);

	if (ret)

		return ret;



	for (i = 0; i < max_regulator; i++) {

		config.dev = &pdev->dev;

		config.regmap = mt6397->regmap;