Unverified Commit 6497ca70 authored by Javier Martinez Canillas's avatar Javier Martinez Canillas
Browse files

drm/panel-leadtek-ltk050h3146w: Drop custom DSI write macro 



There is a macro for this already in the <drm/drm_mipi_dsi.h> header, use
that instead and delete the custom DSI write macro defined in the driver.

Signed-off-by: default avatarJavier Martinez Canillas <javierm@redhat.com>
Reviewed-by: default avatarSam Ravnborg <sam@ravnborg.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20230107191822.3787147-4-javierm@redhat.com
parent 8f821edc

drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c

+49 −57
Original line number Diff line number Diff line
@@ -244,14 +244,6 @@ struct ltk050h3146w *panel_to_ltk050h3146w(struct drm_panel *panel) 
	return container_of(panel, struct ltk050h3146w, panel);

}



#define dsi_dcs_write_seq(dsi, cmd, seq...) do {			\

		static const u8 b[] = { cmd, seq };			\

		int ret;						\

		ret = mipi_dsi_dcs_write_buffer(dsi, b, ARRAY_SIZE(b));	\

		if (ret < 0)						\

			return ret;					\

	} while (0)



static int ltk050h3146w_init_sequence(struct ltk050h3146w *ctx)

{

	struct mipi_dsi_device *dsi = to_mipi_dsi_device(ctx->dev);
@@ -261,55 +253,55 @@ static int ltk050h3146w_init_sequence(struct ltk050h3146w *ctx) 
	 * Init sequence was supplied by the panel vendor without much

	 * documentation.

	 */

	dsi_dcs_write_seq(dsi, 0xdf, 0x93, 0x65, 0xf8);

	dsi_dcs_write_seq(dsi, 0xb0, 0x01, 0x03, 0x02, 0x00, 0x64, 0x06,

	mipi_dsi_dcs_write_seq(dsi, 0xdf, 0x93, 0x65, 0xf8);

	mipi_dsi_dcs_write_seq(dsi, 0xb0, 0x01, 0x03, 0x02, 0x00, 0x64, 0x06,

			       0x01);

	dsi_dcs_write_seq(dsi, 0xb2, 0x00, 0xb5);

	dsi_dcs_write_seq(dsi, 0xb3, 0x00, 0xb5);

	dsi_dcs_write_seq(dsi, 0xb7, 0x00, 0xbf, 0x00, 0x00, 0xbf, 0x00);

	mipi_dsi_dcs_write_seq(dsi, 0xb2, 0x00, 0xb5);

	mipi_dsi_dcs_write_seq(dsi, 0xb3, 0x00, 0xb5);

	mipi_dsi_dcs_write_seq(dsi, 0xb7, 0x00, 0xbf, 0x00, 0x00, 0xbf, 0x00);



	dsi_dcs_write_seq(dsi, 0xb9, 0x00, 0xc4, 0x23, 0x07);

	dsi_dcs_write_seq(dsi, 0xbb, 0x02, 0x01, 0x24, 0x00, 0x28, 0x0f,

	mipi_dsi_dcs_write_seq(dsi, 0xb9, 0x00, 0xc4, 0x23, 0x07);

	mipi_dsi_dcs_write_seq(dsi, 0xbb, 0x02, 0x01, 0x24, 0x00, 0x28, 0x0f,

			       0x28, 0x04, 0xcc, 0xcc, 0xcc);

	dsi_dcs_write_seq(dsi, 0xbc, 0x0f, 0x04);

	dsi_dcs_write_seq(dsi, 0xbe, 0x1e, 0xf2);

	dsi_dcs_write_seq(dsi, 0xc0, 0x26, 0x03);

	dsi_dcs_write_seq(dsi, 0xc1, 0x00, 0x12);

	dsi_dcs_write_seq(dsi, 0xc3, 0x04, 0x02, 0x02, 0x76, 0x01, 0x80,

	mipi_dsi_dcs_write_seq(dsi, 0xbc, 0x0f, 0x04);

	mipi_dsi_dcs_write_seq(dsi, 0xbe, 0x1e, 0xf2);

	mipi_dsi_dcs_write_seq(dsi, 0xc0, 0x26, 0x03);

	mipi_dsi_dcs_write_seq(dsi, 0xc1, 0x00, 0x12);

	mipi_dsi_dcs_write_seq(dsi, 0xc3, 0x04, 0x02, 0x02, 0x76, 0x01, 0x80,

			       0x80);

	dsi_dcs_write_seq(dsi, 0xc4, 0x24, 0x80, 0xb4, 0x81, 0x12, 0x0f,

	mipi_dsi_dcs_write_seq(dsi, 0xc4, 0x24, 0x80, 0xb4, 0x81, 0x12, 0x0f,

			       0x16, 0x00, 0x00);

	dsi_dcs_write_seq(dsi, 0xc8, 0x7f, 0x72, 0x67, 0x5d, 0x5d, 0x50,

	mipi_dsi_dcs_write_seq(dsi, 0xc8, 0x7f, 0x72, 0x67, 0x5d, 0x5d, 0x50,

			       0x56, 0x41, 0x59, 0x57, 0x55, 0x70, 0x5b, 0x5f,

			       0x4f, 0x47, 0x38, 0x23, 0x08, 0x7f, 0x72, 0x67,

			       0x5d, 0x5d, 0x50, 0x56, 0x41, 0x59, 0x57, 0x55,

			       0x70, 0x5b, 0x5f, 0x4f, 0x47, 0x38, 0x23, 0x08);

	dsi_dcs_write_seq(dsi, 0xd0, 0x1e, 0x1f, 0x57, 0x58, 0x48, 0x4a,

	mipi_dsi_dcs_write_seq(dsi, 0xd0, 0x1e, 0x1f, 0x57, 0x58, 0x48, 0x4a,

			       0x44, 0x46, 0x40, 0x1f, 0x42, 0x1f, 0x1f, 0x1f,

			       0x1f, 0x1f, 0x1f, 0x1f, 0x1f, 0x1f, 0x1f, 0x1f);

	dsi_dcs_write_seq(dsi, 0xd1, 0x1e, 0x1f, 0x57, 0x58, 0x49, 0x4b,

	mipi_dsi_dcs_write_seq(dsi, 0xd1, 0x1e, 0x1f, 0x57, 0x58, 0x49, 0x4b,

			       0x45, 0x47, 0x41, 0x1f, 0x43, 0x1f, 0x1f, 0x1f,

			       0x1f, 0x1f, 0x1f, 0x1f, 0x1f, 0x1f, 0x1f, 0x1f);

	dsi_dcs_write_seq(dsi, 0xd2, 0x1f, 0x1e, 0x17, 0x18, 0x07, 0x05,

	mipi_dsi_dcs_write_seq(dsi, 0xd2, 0x1f, 0x1e, 0x17, 0x18, 0x07, 0x05,

			       0x0b, 0x09, 0x03, 0x1f, 0x01, 0x1f, 0x1f, 0x1f,

			       0x1f, 0x1f, 0x1f, 0x1f, 0x1f, 0x1f, 0x1f, 0x1f);

	dsi_dcs_write_seq(dsi, 0xd3, 0x1f, 0x1e, 0x17, 0x18, 0x06, 0x04,

	mipi_dsi_dcs_write_seq(dsi, 0xd3, 0x1f, 0x1e, 0x17, 0x18, 0x06, 0x04,

			       0x0a, 0x08, 0x02, 0x1f, 0x00, 0x1f, 0x1f, 0x1f,

			       0x1f, 0x1f, 0x1f, 0x1f, 0x1f, 0x1f, 0x1f, 0x1f);

	dsi_dcs_write_seq(dsi, 0xd4, 0x00, 0x00, 0x00, 0x0c, 0x06, 0x20,

	mipi_dsi_dcs_write_seq(dsi, 0xd4, 0x00, 0x00, 0x00, 0x0c, 0x06, 0x20,

			       0x01, 0x02, 0x00, 0x60, 0x15, 0xb0, 0x30, 0x03,

			       0x04, 0x00, 0x60, 0x72, 0x0a, 0x00, 0x60, 0x08);

	dsi_dcs_write_seq(dsi, 0xd5, 0x00, 0x06, 0x06, 0x00, 0x30, 0x00,

	mipi_dsi_dcs_write_seq(dsi, 0xd5, 0x00, 0x06, 0x06, 0x00, 0x30, 0x00,

			       0x00, 0x00, 0x00, 0x00, 0xbc, 0x50, 0x00, 0x05,

			       0x21, 0x00, 0x60);

	dsi_dcs_write_seq(dsi, 0xdd, 0x2c, 0xa3, 0x00);

	dsi_dcs_write_seq(dsi, 0xde, 0x02);

	dsi_dcs_write_seq(dsi, 0xb2, 0x32, 0x1c);

	dsi_dcs_write_seq(dsi, 0xb7, 0x3b, 0x70, 0x00, 0x04);

	dsi_dcs_write_seq(dsi, 0xc1, 0x11);

	dsi_dcs_write_seq(dsi, 0xbb, 0x21, 0x22, 0x23, 0x24, 0x36, 0x37);

	dsi_dcs_write_seq(dsi, 0xc2, 0x20, 0x38, 0x1e, 0x84);

	dsi_dcs_write_seq(dsi, 0xde, 0x00);

	mipi_dsi_dcs_write_seq(dsi, 0xdd, 0x2c, 0xa3, 0x00);

	mipi_dsi_dcs_write_seq(dsi, 0xde, 0x02);

	mipi_dsi_dcs_write_seq(dsi, 0xb2, 0x32, 0x1c);

	mipi_dsi_dcs_write_seq(dsi, 0xb7, 0x3b, 0x70, 0x00, 0x04);

	mipi_dsi_dcs_write_seq(dsi, 0xc1, 0x11);

	mipi_dsi_dcs_write_seq(dsi, 0xbb, 0x21, 0x22, 0x23, 0x24, 0x36, 0x37);

	mipi_dsi_dcs_write_seq(dsi, 0xc2, 0x20, 0x38, 0x1e, 0x84);

	mipi_dsi_dcs_write_seq(dsi, 0xde, 0x00);



	ret = mipi_dsi_dcs_set_tear_on(dsi, 1);

	if (ret < 0) {