Commit 648106c3 authored by Amit Cohen's avatar Amit Cohen Committed by David S. Miller
Browse files

IPv4: Extend 'fib_notify_on_flag_change' sysctl 



Add the value '2' to 'fib_notify_on_flag_change' to allow sending
notifications only for failed route installation.

Separate value is added for such notifications because there are less of
them, so they do not impact performance and some users will find them more
important.

Signed-off-by: default avatarAmit Cohen <amcohen@nvidia.com>
Signed-off-by: default avatarIdo Schimmel <idosch@nvidia.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 36c5100e

Documentation/networking/ip-sysctl.rst

+2 −1
Original line number Diff line number Diff line
@@ -180,7 +180,7 @@ min_adv_mss - INTEGER 


fib_notify_on_flag_change - INTEGER

        Whether to emit RTM_NEWROUTE notifications whenever RTM_F_OFFLOAD/

        RTM_F_TRAP flags are changed.

        RTM_F_TRAP/RTM_F_OFFLOAD_FAILED flags are changed.



        After installing a route to the kernel, user space receives an

        acknowledgment, which means the route was installed in the kernel,
@@ -197,6 +197,7 @@ fib_notify_on_flag_change - INTEGER 


        - 0 - Do not emit notifications.

        - 1 - Emit notifications.

        - 2 - Emit notifications only for RTM_F_OFFLOAD_FAILED flag change.



IP Fragmentation:

net/ipv4/fib_trie.c

+6 −0
Original line number Diff line number Diff line
@@ -1053,6 +1053,12 @@ void fib_alias_hw_flags_set(struct net *net, const struct fib_rt_info *fri) 


	fa_match->offload = fri->offload;

	fa_match->trap = fri->trap;



	/* 2 means send notifications only if offload_failed was changed. */

	if (net->ipv4.sysctl_fib_notify_on_flag_change == 2 &&

	    fa_match->offload_failed == fri->offload_failed)

		goto out;



	fa_match->offload_failed = fri->offload_failed;



	if (!net->ipv4.sysctl_fib_notify_on_flag_change)

net/ipv4/sysctl_net_ipv4.c

+1 −1
Original line number Diff line number Diff line
@@ -1361,7 +1361,7 @@ static struct ctl_table ipv4_net_table[] = { 
		.mode		= 0644,

		.proc_handler	= proc_dointvec_minmax,

		.extra1		= SYSCTL_ZERO,

		.extra2		= SYSCTL_ONE,

		.extra2		= &two,

	},

	{ }

};