Commit 6474a4e5 authored by Niklas Cassel's avatar Niklas Cassel Committed by Lorenzo Pieralisi
Browse files

PCI: endpoint: Make sure that BAR_5 does not have 64-bit flag set when clearing 



Since a 64-bit BAR consists of a BAR pair, and since there is no
BAR after BAR_5, BAR_5 cannot be 64-bits wide.

This sanity check is done in pci_epc_clear_bar(), so that we don't need
to do this sanity check in all epc->ops->clear_bar() implementations.

Signed-off-by: default avatarNiklas Cassel <niklas.cassel@axis.com>
Signed-off-by: default avatarLorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Acked-by: default avatarKishon Vijay Abraham I <kishon@ti.com>
parent 77d08dbd

drivers/pci/endpoint/pci-epc-core.c

+3 −1
Original line number Diff line number Diff line
@@ -285,7 +285,9 @@ void pci_epc_clear_bar(struct pci_epc *epc, u8 func_no, 
{

	unsigned long flags;



	if (IS_ERR_OR_NULL(epc) || func_no >= epc->max_functions)

	if (IS_ERR_OR_NULL(epc) || func_no >= epc->max_functions ||

	    (epf_bar->barno == BAR_5 &&

	     epf_bar->flags & PCI_BASE_ADDRESS_MEM_TYPE_64))

		return;



	if (!epc->ops->clear_bar)