Commit 6464d5b8 authored by Colin Ian King's avatar Colin Ian King Committed by Martin K. Petersen
Browse files

scsi: megaraid_sas: Remove redundant variable cmd_type 

The variable cmd_type is assigned a value but it is never read. The
variable and the assignment are redundant and can be removed.

Cleans up clang scan build warning:

 drivers/scsi/megaraid/megaraid_sas_fusion.c:3228:10: warning: Although
 the value stored to 'cmd_type' is used in the enclosing expression, the
 value is never actually read from 'cmd_type' [deadcode.DeadStores]

Link: https://lore.kernel.org/r/20220730124509.148457-1-colin.i.king@gmail.com


Signed-off-by: default avatarColin Ian King <colin.i.king@gmail.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 554b117e

drivers/scsi/megaraid/megaraid_sas_fusion.c

+1 −2
Original line number Diff line number Diff line
@@ -3199,7 +3199,6 @@ megasas_build_io_fusion(struct megasas_instance *instance, 
			struct megasas_cmd_fusion *cmd)

{

	int sge_count;

	u8  cmd_type;

	u16 pd_index = 0;

	u8 drive_type = 0;

	struct MPI2_RAID_SCSI_IO_REQUEST *io_request = cmd->io_request;
@@ -3225,7 +3224,7 @@ megasas_build_io_fusion(struct megasas_instance *instance, 
	 */

	io_request->IoFlags = cpu_to_le16(scp->cmd_len);



	switch (cmd_type = megasas_cmd_type(scp)) {

	switch (megasas_cmd_type(scp)) {

	case READ_WRITE_LDIO:

		megasas_build_ldio_fusion(instance, scp, cmd);

		break;