Commit 644ee702 authored by Bartosz Golaszewski's avatar Bartosz Golaszewski
Browse files

gpio: mvebu: fix irq domain leak 



Uwe Kleine-König pointed out we still have one resource leak in the mvebu
driver triggered on driver detach. Let's address it with a custom devm
action.

Fixes: 812d4788 ("gpio/mvebu: Use irq_domain_add_linear")
Signed-off-by: default avatarBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Reviewed-by: default avatarAndy Shevchenko <andy.shevchenko@gmail.com>
Reviewed-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
parent 1945063e

drivers/gpio/gpio-mvebu.c

+13 −5
Original line number Diff line number Diff line
@@ -1112,6 +1112,13 @@ static int mvebu_gpio_probe_syscon(struct platform_device *pdev, 
	return 0;

}



static void mvebu_gpio_remove_irq_domain(void *data)

{

	struct irq_domain *domain = data;



	irq_domain_remove(domain);

}



static int mvebu_gpio_probe(struct platform_device *pdev)

{

	struct mvebu_gpio_chip *mvchip;
@@ -1246,13 +1253,18 @@ static int mvebu_gpio_probe(struct platform_device *pdev) 
		return -ENODEV;

	}



	err = devm_add_action_or_reset(&pdev->dev, mvebu_gpio_remove_irq_domain,

				       mvchip->domain);

	if (err)

		return err;



	err = irq_alloc_domain_generic_chips(

	    mvchip->domain, ngpios, 2, np->name, handle_level_irq,

	    IRQ_NOREQUEST | IRQ_NOPROBE | IRQ_LEVEL, 0, 0);

	if (err) {

		dev_err(&pdev->dev, "couldn't allocate irq chips %s (DT).\n",

			mvchip->chip.label);

		goto err_domain;

		return err;

	}



	/*
@@ -1292,10 +1304,6 @@ static int mvebu_gpio_probe(struct platform_device *pdev) 
	}



	return 0;



err_domain:

	irq_domain_remove(mvchip->domain);

	return err;

}



static struct platform_driver mvebu_gpio_driver = {