Commit 643f5cfa authored by Alexander Aring's avatar Alexander Aring Committed by David Teigland
Browse files

fs: dlm: cleanup lock order 



This patch cleanups the lock order to hold at first the close_lock and
then held the nodes_srcu read lock. Probably it will never be a problem
as nodes_srcu is only a read lock preventing the node pointer getting
freed.

Signed-off-by: default avatarAlexander Aring <aahringo@redhat.com>
Signed-off-by: default avatarDavid Teigland <teigland@redhat.com>
parent c84c4733

fs/dlm/midcomms.c

+2 −2
Original line number Diff line number Diff line
@@ -1489,12 +1489,12 @@ int dlm_midcomms_close(int nodeid) 


	synchronize_srcu(&nodes_srcu);



	idx = srcu_read_lock(&nodes_srcu);

	mutex_lock(&close_lock);

	idx = srcu_read_lock(&nodes_srcu);

	node = nodeid2node(nodeid, 0);

	if (!node) {

		mutex_unlock(&close_lock);

		srcu_read_unlock(&nodes_srcu, idx);

		mutex_unlock(&close_lock);

		return dlm_lowcomms_close(nodeid);

	}