Unverified Commit 642ba844 authored by openeuler-ci-bot's avatar openeuler-ci-bot Committed by Gitee
Browse files

!11264 media: xc2028: avoid use-after-free in load_firmware_cb() 

Merge Pull Request from: @ci-robot 
 
PR sync from: Wenyu Huang <huangwenyu5@huawei.com>
https://mailweb.openeuler.org/hyperkitty/list/kernel@openeuler.org/message/SPNIEK6GMOV6Z2LH4BIXYZT2HMFFNQ6H/ 
 
https://gitee.com/src-openeuler/kernel/issues/IAMMTD 
 
Link:https://gitee.com/openeuler/kernel/pulls/11264

 

Reviewed-by: default avatarZucheng Zheng <zhengzucheng@huawei.com>
Reviewed-by: default avatarLiu YongQiang <liuyongqiang13@huawei.com>
Signed-off-by: default avatarZhang Changzhong <zhangchangzhong@huawei.com>
parents 5ceb8241 2e904f3e

drivers/media/tuners/tuner-xc2028.c

+8 −1
Original line number Diff line number Diff line
@@ -1362,9 +1362,16 @@ static void load_firmware_cb(const struct firmware *fw, 
			     void *context)

{

	struct dvb_frontend *fe = context;

	struct xc2028_data *priv = fe->tuner_priv;

	struct xc2028_data *priv;

	int rc;



	if (!fe) {

		pr_warn("xc2028: No frontend in %s\n", __func__);

		return;

	}



	priv = fe->tuner_priv;



	tuner_dbg("request_firmware_nowait(): %s\n", fw ? "OK" : "error");

	if (!fw) {

		tuner_err("Could not load firmware %s.\n", priv->fname);