Commit 641e9691 authored Sep 15, 2023 by Takashi Iwai

ALSA: firewire: Fix -Wformat-truncation warning for longname string

The filling of card->longname can be gracefully truncated, as it's
only informative.  Use scnprintf() and suppress the superfluous
compile warning with -Wformat-truncation.

Link: https://lore.kernel.org/r/20230915082802.28684-11-tiwai@suse.de


Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Tested-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Takashi Iwai <tiwai@suse.de>

parent 7272b8bf

sound/firewire/fireworks/fireworks.c

+5 −5

Original line number	Diff line number	Diff line
		@@ -93,7 +93,7 @@ get_hardware_info(struct snd_efw *efw)
		strcpy(efw->card->driver, "Fireworks");
		strcpy(efw->card->shortname, hwinfo->model_name);
		strcpy(efw->card->mixername, hwinfo->model_name);
		snprintf(efw->card->longname, sizeof(efw->card->longname),
		scnprintf(efw->card->longname, sizeof(efw->card->longname),
		"%s %s v%s, GUID %08x%08x at %s, S%d",
		hwinfo->vendor_name, hwinfo->model_name, version,
		hwinfo->guid_hi, hwinfo->guid_lo,

sound/firewire/oxfw/oxfw.c

+5 −5

Original line number	Diff line number	Diff line
		@@ -108,7 +108,7 @@ static int name_card(struct snd_oxfw oxfw, const struct ieee1394_device_id ent
		strcpy(oxfw->card->mixername, m);
		strcpy(oxfw->card->shortname, m);

		snprintf(oxfw->card->longname, sizeof(oxfw->card->longname),
		scnprintf(oxfw->card->longname, sizeof(oxfw->card->longname),
		"%s %s (OXFW%x %04x), GUID %08x%08x at %s, S%d",
		v, m, firmware >> 20, firmware & 0xffff,
		fw_dev->config_rom[3], fw_dev->config_rom[4],