Commit 640fcdbc authored by Dan Carpenter's avatar Dan Carpenter Committed by Saeed Mahameed
Browse files

net/mlx5: E-Switch, Fix an Oops in error handling code 



The error handling dereferences "vport".  There is nothing we can do if
it is an error pointer except returning the error code.

Fixes: 133dcfc5 ("net/mlx5: E-Switch, Alloc and free unique metadata for match")
Signed-off-by: default avatarDan Carpenter <error27@gmail.com>
Reviewed-by: default avatarRoi Dayan <roid@nvidia.com>
Signed-off-by: default avatarSaeed Mahameed <saeedm@nvidia.com>
parent 44d55318

drivers/net/ethernet/mellanox/mlx5/core/esw/acl/ingress_ofld.c

+1 −2
Original line number Diff line number Diff line
@@ -364,8 +364,7 @@ int mlx5_esw_acl_ingress_vport_metadata_update(struct mlx5_eswitch *esw, u16 vpo 


	if (WARN_ON_ONCE(IS_ERR(vport))) {

		esw_warn(esw->dev, "vport(%d) invalid!\n", vport_num);

		err = PTR_ERR(vport);

		goto out;

		return PTR_ERR(vport);

	}



	esw_acl_ingress_ofld_rules_destroy(esw, vport);