Commit 63fa7f26 authored Jul 12, 2022 by Quinn Tran Committed by Martin K. Petersen Jul 18, 2022

scsi: qla2xxx: Fix imbalance vha->vref_count

vref_count took an extra decrement in the task management path.  Add an
extra ref count to compensate the imbalance.

Link: https://lore.kernel.org/r/20220713052045.10683-7-njavali@marvell.com


Cc: stable@vger.kernel.org
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Quinn Tran <qutran@marvell.com>
Signed-off-by: Nilesh Javali <njavali@marvell.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

parent c019cd65

drivers/scsi/qla2xxx/qla_init.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -168,6 +168,7 @@ int qla24xx_async_abort_cmd(srb_t *cmd_sp, bool wait)
		struct srb_iocb *abt_iocb;
		srb_t *sp;
		int rval = QLA_FUNCTION_FAILED;
		uint8_t bail;

		/* ref: INIT for ABTS command */
		sp = qla2xxx_get_qpair_sp(cmd_sp->vha, cmd_sp->qpair, cmd_sp->fcport,
		@@ -175,6 +176,7 @@ int qla24xx_async_abort_cmd(srb_t *cmd_sp, bool wait)
		if (!sp)
		return QLA_MEMORY_ALLOC_FAILED;

		QLA_VHA_MARK_BUSY(vha, bail);
		abt_iocb = &sp->u.iocb_cmd;
		sp->type = SRB_ABT_CMD;
		sp->name = "abort";
		@@ -2018,12 +2020,14 @@ qla2x00_async_tm_cmd(fc_port_t *fcport, uint32_t flags, uint32_t lun,
		struct srb_iocb *tm_iocb;
		srb_t *sp;
		int rval = QLA_FUNCTION_FAILED;
		uint8_t bail;

		/* ref: INIT */
		sp = qla2x00_get_sp(vha, fcport, GFP_KERNEL);
		if (!sp)
		goto done;

		QLA_VHA_MARK_BUSY(vha, bail);
		sp->type = SRB_TM_CMD;
		sp->name = "tmf";
		qla2x00_init_async_sp(sp, qla2x00_get_async_timeout(vha),