Commit 63f94e94 authored by Steve French's avatar Steve French
Browse files

cifs: fix missing null session check in mount



Although it is unlikely to be have ended up with a null
session pointer calling cifs_try_adding_channels in cifs_mount.
Coverity correctly notes that we are already checking for
it earlier (when we return from do_dfs_failover), so at
a minimum to clarify the code we should make sure we also
check for it when we exit the loop so we don't end up calling
cifs_try_adding_channels or mount_setup_tlink with a null
ses pointer.

Addresses-Coverity: 1505608 ("Derefernce after null check")
Reviewed-by: default avatarPaulo Alcantara (SUSE) <pc@cjr.nz>
Signed-off-by: default avatarSteve French <stfrench@microsoft.com>
parent 507345b5
Loading
Loading
Loading
Loading
+1 −1
Original line number Diff line number Diff line
@@ -3508,7 +3508,7 @@ int cifs_mount(struct cifs_sb_info *cifs_sb, struct smb3_fs_context *ctx)
			rc = -ELOOP;
	} while (rc == -EREMOTE);

	if (rc || !tcon)
	if (rc || !tcon || !ses)
		goto error;

	kfree(ref_path);