Commit 63f77a71 authored by Brett Creeley's avatar Brett Creeley Committed by Alex Williamson
Browse files

vfio/pds: register with the pds_core PF 



The pds_core driver will supply adminq services, so find the PF
and register with the DSC services.

Use the following commands to enable a VF:
echo 1 > /sys/bus/pci/drivers/pds_core/$PF_BDF/sriov_numvfs

Signed-off-by: default avatarBrett Creeley <brett.creeley@amd.com>
Signed-off-by: default avatarShannon Nelson <shannon.nelson@amd.com>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Reviewed-by: default avatarKevin Tian <kevin.tian@intel.com>
Reviewed-by: default avatarShameer Kolothum <shameerali.kolothum.thodi@huawei.com>
Reviewed-by: default avatarJason Gunthorpe <jgg@nvidia.com>
Link: https://lore.kernel.org/r/20230807205755.29579-5-brett.creeley@amd.com


Signed-off-by: default avatarAlex Williamson <alex.williamson@redhat.com>
parent b021d05e

drivers/vfio/pci/pds/Makefile

+1 −0
Original line number Diff line number Diff line
@@ -4,5 +4,6 @@ 
obj-$(CONFIG_PDS_VFIO_PCI) += pds-vfio-pci.o



pds-vfio-pci-y := \

	cmds.o		\

	pci_drv.o	\

	vfio_dev.o

drivers/vfio/pci/pds/cmds.c

0 → 100644
+54 −0
Original line number Diff line number Diff line 
// SPDX-License-Identifier: GPL-2.0

/* Copyright(c) 2023 Advanced Micro Devices, Inc. */



#include <linux/io.h>

#include <linux/types.h>



#include <linux/pds/pds_common.h>

#include <linux/pds/pds_core_if.h>

#include <linux/pds/pds_adminq.h>



#include "vfio_dev.h"

#include "cmds.h"



int pds_vfio_register_client_cmd(struct pds_vfio_pci_device *pds_vfio)

{

	struct pci_dev *pdev = pds_vfio_to_pci_dev(pds_vfio);

	char devname[PDS_DEVNAME_LEN];

	struct pdsc *pdsc;

	int ci;



	snprintf(devname, sizeof(devname), "%s.%d-%u", PDS_VFIO_LM_DEV_NAME,

		 pci_domain_nr(pdev->bus),

		 PCI_DEVID(pdev->bus->number, pdev->devfn));



	pdsc = pdsc_get_pf_struct(pdev);

	if (IS_ERR(pdsc))

		return PTR_ERR(pdsc);



	ci = pds_client_register(pdsc, devname);

	if (ci < 0)

		return ci;



	pds_vfio->client_id = ci;



	return 0;

}



void pds_vfio_unregister_client_cmd(struct pds_vfio_pci_device *pds_vfio)

{

	struct pci_dev *pdev = pds_vfio_to_pci_dev(pds_vfio);

	struct pdsc *pdsc;

	int err;



	pdsc = pdsc_get_pf_struct(pdev);

	if (IS_ERR(pdsc))

		return;



	err = pds_client_unregister(pdsc, pds_vfio->client_id);

	if (err)

		dev_err(&pdev->dev, "unregister from DSC failed: %pe\n",

			ERR_PTR(err));



	pds_vfio->client_id = 0;

}

drivers/vfio/pci/pds/cmds.h

0 → 100644
+10 −0
Original line number Diff line number Diff line 
/* SPDX-License-Identifier: GPL-2.0 */

/* Copyright(c) 2023 Advanced Micro Devices, Inc. */



#ifndef _CMDS_H_

#define _CMDS_H_



int pds_vfio_register_client_cmd(struct pds_vfio_pci_device *pds_vfio);

void pds_vfio_unregister_client_cmd(struct pds_vfio_pci_device *pds_vfio);



#endif /* _CMDS_H_ */

drivers/vfio/pci/pds/pci_drv.c

+14 −0
Original line number Diff line number Diff line
@@ -8,9 +8,13 @@ 
#include <linux/types.h>

#include <linux/vfio.h>



#include <linux/pds/pds_common.h>

#include <linux/pds/pds_core_if.h>

#include <linux/pds/pds_adminq.h>



#include "vfio_dev.h"

#include "pci_drv.h"

#include "cmds.h"



#define PDS_VFIO_DRV_DESCRIPTION	"AMD/Pensando VFIO Device Driver"

#define PCI_VENDOR_ID_PENSANDO		0x1dd8
@@ -32,8 +36,17 @@ static int pds_vfio_pci_probe(struct pci_dev *pdev, 
	if (err)

		goto out_put_vdev;



	err = pds_vfio_register_client_cmd(pds_vfio);

	if (err) {

		dev_err(&pdev->dev, "failed to register as client: %pe\n",

			ERR_PTR(err));

		goto out_unregister_coredev;

	}



	return 0;



out_unregister_coredev:

	vfio_pci_core_unregister_device(&pds_vfio->vfio_coredev);

out_put_vdev:

	vfio_put_device(&pds_vfio->vfio_coredev.vdev);

	return err;
@@ -43,6 +56,7 @@ static void pds_vfio_pci_remove(struct pci_dev *pdev) 
{

	struct pds_vfio_pci_device *pds_vfio = pds_vfio_pci_drvdata(pdev);



	pds_vfio_unregister_client_cmd(pds_vfio);

	vfio_pci_core_unregister_device(&pds_vfio->vfio_coredev);

	vfio_put_device(&pds_vfio->vfio_coredev.vdev);

}

drivers/vfio/pci/pds/pci_drv.h

0 → 100644
+9 −0
Original line number Diff line number Diff line 
/* SPDX-License-Identifier: GPL-2.0 */

/* Copyright(c) 2023 Advanced Micro Devices, Inc. */



#ifndef _PCI_DRV_H

#define _PCI_DRV_H



#include <linux/pci.h>



#endif /* _PCI_DRV_H */