Commit 63e36a38 authored by Qiushi Wu's avatar Qiushi Wu Committed by Mauro Carvalho Chehab
Browse files

media: platform: fcp: Fix a reference count leak. 



pm_runtime_get_sync() increments the runtime PM usage counter even
when it returns an error code, causing incorrect ref count if
pm_runtime_put_noidle() is not called in error handling paths.
Thus call pm_runtime_put_noidle() if pm_runtime_get_sync() fails.

Fixes: 6eaafbdb ("[media] v4l: rcar-fcp: Keep the coding style consistent")
Signed-off-by: default avatarQiushi Wu <wu000273@umn.edu>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
parent 884d638e

drivers/media/platform/rcar-fcp.c

+3 −1
Original line number Diff line number Diff line
@@ -102,8 +102,10 @@ int rcar_fcp_enable(struct rcar_fcp_device *fcp) 
		return 0;



	ret = pm_runtime_get_sync(fcp->dev);

	if (ret < 0)

	if (ret < 0) {

		pm_runtime_put_noidle(fcp->dev);

		return ret;

	}



	return 0;

}