Commit 63e34e70 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Greg Kroah-Hartman
Browse files

tty: vcc: Drop impossible to hit WARN_ON 



vcc_get() returns the port that has provided port->index. As the port that
is about to be removed isn't removed yet this trivially will find this
port. So simplify the call to not assign an identical value to the port
pointer and drop the warning that is never hit.

Reviewed-by: default avatarJiri Slaby <jirislaby@kernel.org>
Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20210114175718.137483-4-u.kleine-koenig@pengutronix.de


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 6da629c8

drivers/tty/vcc.c

+2 −5
Original line number Diff line number Diff line
@@ -692,12 +692,9 @@ static int vcc_remove(struct vio_dev *vdev) 
		tty_vhangup(port->tty);



	/* Get exclusive reference to VCC, ensures that there are no other

	 * clients to this port

	 * clients to this port. This cannot fail.

	 */

	port = vcc_get(port->index, true);



	if (WARN_ON(!port))

		return -ENODEV;

	vcc_get(port->index, true);



	tty_unregister_device(vcc_tty_driver, port->index);