Commit 63cf3238 authored by Wong Vee Khee's avatar Wong Vee Khee Committed by David S. Miller
Browse files

ethtool: fix incorrect datatype in set_eee ops 



The member 'tx_lpi_timer' is defined with __u32 datatype in the ethtool
header file. Hence, we should use ethnl_update_u32() in set_eee ops.

Fixes: fd77be7b ("ethtool: set EEE settings with EEE_SET request")
Cc: <stable@vger.kernel.org> # 5.10.x
Cc: Michal Kubecek <mkubecek@suse.cz>
Signed-off-by: default avatarWong Vee Khee <vee.khee.wong@linux.intel.com>
Reviewed-by: default avatarJakub Kicinski <kuba@kernel.org>
Reviewed-by: default avatarMichal Kubecek <mkubecek@suse.cz>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent ed7bedd2

net/ethtool/eee.c

+2 −2
Original line number Diff line number Diff line
@@ -169,7 +169,7 @@ int ethnl_set_eee(struct sk_buff *skb, struct genl_info *info) 
	ethnl_update_bool32(&eee.eee_enabled, tb[ETHTOOL_A_EEE_ENABLED], &mod);

	ethnl_update_bool32(&eee.tx_lpi_enabled,

			    tb[ETHTOOL_A_EEE_TX_LPI_ENABLED], &mod);

	ethnl_update_bool32(&eee.tx_lpi_timer, tb[ETHTOOL_A_EEE_TX_LPI_TIMER],

	ethnl_update_u32(&eee.tx_lpi_timer, tb[ETHTOOL_A_EEE_TX_LPI_TIMER],

			 &mod);

	ret = 0;

	if (!mod)