Commit 63c3b5d2 authored by GONG, Ruiqi's avatar GONG, Ruiqi Committed by Casey Schaufler
Browse files

smack: Replace kzalloc + strncpy with kstrndup 

Simplify the code by using kstrndup instead of kzalloc and strncpy in
smk_parse_smack(), which meanwhile remove strncpy as [1] suggests.

[1]: https://github.com/KSPP/linux/issues/90



Signed-off-by: default avatarGONG, Ruiqi <gongruiqi1@huawei.com>
Signed-off-by: default avatarCasey Schaufler <casey@schaufler-ca.com>
parent f2906aa8

security/smack/smack_access.c

+2 −5
Original line number Diff line number Diff line
@@ -465,12 +465,9 @@ char *smk_parse_smack(const char *string, int len) 
	if (i == 0 || i >= SMK_LONGLABEL)

		return ERR_PTR(-EINVAL);



	smack = kzalloc(i + 1, GFP_NOFS);

	if (smack == NULL)

	smack = kstrndup(string, i, GFP_NOFS);

	if (!smack)

		return ERR_PTR(-ENOMEM);



	strncpy(smack, string, i);



	return smack;

}