Commit 63ba54a5 authored by Jiri Pirko's avatar Jiri Pirko Committed by Jakub Kicinski
Browse files

devlink: add instance lock assertion in devl_is_registered() 



After region and linecard lock removals, this helper is always supposed
to be called with instance lock held. So put the assertion here and
remove the comment which is no longer accurate.

Signed-off-by: default avatarJiri Pirko <jiri@nvidia.com>
Reviewed-by: default avatarJacob Keller <jacob.e.keller@intel.com>
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 543753d9

net/devlink/devl_internal.h

+1 −3
Original line number Diff line number Diff line
@@ -85,9 +85,7 @@ struct devlink *devlinks_xa_find_get(struct net *net, unsigned long *indexp); 


static inline bool devl_is_registered(struct devlink *devlink)

{

	/* To prevent races the caller must hold the instance lock

	 * or another lock taken during unregistration.

	 */

	devl_assert_locked(devlink);

	return xa_get_mark(&devlinks, devlink->index, DEVLINK_REGISTERED);

}