Commit 63b1a7dd authored Jul 21, 2022 by Zijun Hu Committed by Luiz Augusto von Dentz Jul 21, 2022

Bluetooth: hci_sync: Remove HCI_QUIRK_BROKEN_ERR_DATA_REPORTING



Core driver addtionally checks LMP feature bit "Erroneous Data Reporting"
instead of quirk HCI_QUIRK_BROKEN_ERR_DATA_REPORTING to decide if HCI
commands HCI_Read|Write_Default_Erroneous_Data_Reporting are broken, so
remove this unnecessary quirk.

Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
Tested-by: Zijun Hu <quic_zijuhu@quicinc.com>
Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

parent e168f690

include/net/bluetooth/hci.h

+0 −11

Original line number	Diff line number	Diff line
		@@ -228,17 +228,6 @@ enum {
		*/
		HCI_QUIRK_VALID_LE_STATES,

		/* When this quirk is set, then erroneous data reporting
		* is ignored. This is mainly due to the fact that the HCI
		* Read Default Erroneous Data Reporting command is advertised,
		* but not supported; these controllers often reply with unknown
		* command and tend to lock up randomly. Needing a hard reset.
		*
		* This quirk can be set before hci_register_dev is called or
		* during the hdev->setup vendor callback.
		*/
		HCI_QUIRK_BROKEN_ERR_DATA_REPORTING,

		/*
		* When this quirk is set, then the hci_suspend_notifier is not
		* registered. This is intended for devices which drop completely

net/bluetooth/hci_sync.c

+0 −3

Original line number	Diff line number	Diff line
		@@ -3865,9 +3865,6 @@ static const struct {
		HCI_QUIRK_BROKEN(STORED_LINK_KEY,
		"HCI Delete Stored Link Key command is advertised, "
		"but not supported."),
		HCI_QUIRK_BROKEN(ERR_DATA_REPORTING,
		"HCI Read Default Erroneous Data Reporting command is "
		"advertised, but not supported."),
		HCI_QUIRK_BROKEN(READ_TRANSMIT_POWER,
		"HCI Read Transmit Power Level command is advertised, "
		"but not supported."),