Commit 632f1ca3 authored by Stephan Gerhold's avatar Stephan Gerhold Committed by Bjorn Andersson
Browse files

remoteproc: qcom_q6v5: Use devm_qcom_smem_state_get() to fix missing put() 



qcom_q6v5 is requesting a smem state with qcom_smem_state_get() but
qcom_smem_state_put() is not called anywhere. Use the new devm_()
variant to fix this without making the code more complicated.

Fixes: 051fb70f ("remoteproc: qcom: Driver for the self-authenticating Hexagon v5")
Signed-off-by: default avatarStephan Gerhold <stephan@gerhold.net>
Link: https://lore.kernel.org/r/20210618111556.53416-2-stephan@gerhold.net


Signed-off-by: default avatarBjorn Andersson <bjorn.andersson@linaro.org>
parent 61d1961a

drivers/remoteproc/qcom_q6v5.c

+1 −1
Original line number Diff line number Diff line
@@ -280,7 +280,7 @@ int qcom_q6v5_init(struct qcom_q6v5 *q6v5, struct platform_device *pdev, 
		return ret;

	}



	q6v5->state = qcom_smem_state_get(&pdev->dev, "stop", &q6v5->stop_bit);

	q6v5->state = devm_qcom_smem_state_get(&pdev->dev, "stop", &q6v5->stop_bit);

	if (IS_ERR(q6v5->state)) {

		dev_err(&pdev->dev, "failed to acquire stop state\n");

		return PTR_ERR(q6v5->state);