Commit 631ed4b0 authored by Jeff Layton's avatar Jeff Layton Committed by Ilya Dryomov
Browse files

ceph: shut down mount on bad mdsmap or fsmap decode 

As Greg pointed out, if we get a mangled mdsmap or fsmap, then something
has gone very wrong, and we should avoid doing any activity on the
filesystem.

When this occurs, shut down the mount the same way we would with a
forced umount by calling ceph_umount_begin when decoding fails on either
map. This causes most operations done against the filesystem to return
an error. Any dirty data or caps in the cache will be dropped as well.

The effect is not reversible, so the only remedy is to umount.

[ idryomov: print fsmap decoding error ]

URL: https://tracker.ceph.com/issues/52303


Signed-off-by: default avatarJeff Layton <jlayton@kernel.org>
Acked-by: default avatarGreg Farnum <gfarnum@redhat.com>
Signed-off-by: default avatarIlya Dryomov <idryomov@gmail.com>
parent 0e24421a

fs/ceph/mds_client.c

+4 −2
Original line number Diff line number Diff line
@@ -4983,7 +4983,8 @@ void ceph_mdsc_handle_fsmap(struct ceph_mds_client *mdsc, struct ceph_msg *msg) 
	return;



bad:

	pr_err("error decoding fsmap\n");

	pr_err("error decoding fsmap %d. Shutting down mount.\n", err);

	ceph_umount_begin(mdsc->fsc->sb);

err_out:

	mutex_lock(&mdsc->mutex);

	mdsc->mdsmap_err = err;
@@ -5050,7 +5051,8 @@ void ceph_mdsc_handle_mdsmap(struct ceph_mds_client *mdsc, struct ceph_msg *msg) 
bad_unlock:

	mutex_unlock(&mdsc->mutex);

bad:

	pr_err("error decoding mdsmap %d\n", err);

	pr_err("error decoding mdsmap %d. Shutting down mount.\n", err);

	ceph_umount_begin(mdsc->fsc->sb);

	return;

}

fs/ceph/super.c

+1 −1
Original line number Diff line number Diff line
@@ -842,7 +842,7 @@ static void __ceph_umount_begin(struct ceph_fs_client *fsc) 
 * ceph_umount_begin - initiate forced umount.  Tear down the

 * mount, skipping steps that may hang while waiting for server(s).

 */

static void ceph_umount_begin(struct super_block *sb)

void ceph_umount_begin(struct super_block *sb)

{

	struct ceph_fs_client *fsc = ceph_sb_to_client(sb);

fs/ceph/super.h

+1 −0
Original line number Diff line number Diff line
@@ -941,6 +941,7 @@ extern void ceph_put_snapid_map(struct ceph_mds_client* mdsc, 
				struct ceph_snapid_map *sm);

extern void ceph_trim_snapid_map(struct ceph_mds_client *mdsc);

extern void ceph_cleanup_snapid_map(struct ceph_mds_client *mdsc);

void ceph_umount_begin(struct super_block *sb);





/*