Commit 63174f61 authored by Nathan Chancellor's avatar Nathan Chancellor Committed by Linus Torvalds
Browse files

kernel/extable.c: use address-of operator on section symbols 



Clang warns:

../kernel/extable.c:37:52: warning: array comparison always evaluates to
a constant [-Wtautological-compare]
        if (main_extable_sort_needed && __stop___ex_table > __start___ex_table) {
                                                          ^
1 warning generated.

These are not true arrays, they are linker defined symbols, which are just
addresses.  Using the address of operator silences the warning and does
not change the resulting assembly with either clang/ld.lld or gcc/ld
(tested with diff + objdump -Dr).

Suggested-by: default avatarNick Desaulniers <ndesaulniers@google.com>
Signed-off-by: default avatarNathan Chancellor <natechancellor@gmail.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Reviewed-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Link: https://github.com/ClangBuiltLinux/linux/issues/892
Link: http://lkml.kernel.org/r/20200219202036.45702-1-natechancellor@gmail.com


Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 06e85c7e

kernel/extable.c

+2 −1
Original line number Diff line number Diff line
@@ -34,7 +34,8 @@ u32 __initdata __visible main_extable_sort_needed = 1; 
/* Sort the kernel's built-in exception table */

void __init sort_main_extable(void)

{

	if (main_extable_sort_needed && __stop___ex_table > __start___ex_table) {

	if (main_extable_sort_needed &&

	    &__stop___ex_table > &__start___ex_table) {

		pr_notice("Sorting __ex_table...\n");

		sort_extable(__start___ex_table, __stop___ex_table);

	}