Commit 6305d821 authored by Kuniyuki Iwashima's avatar Kuniyuki Iwashima Committed by David S. Miller
Browse files

igmp: Fix a data-race around sysctl_igmp_max_memberships. 



While reading sysctl_igmp_max_memberships, it can be changed concurrently.
Thus, we need to add READ_ONCE() to its reader.

Fixes: 1da177e4 ("Linux-2.6.12-rc2")
Signed-off-by: default avatarKuniyuki Iwashima <kuniyu@amazon.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent f6da2267

net/ipv4/igmp.c

+1 −1
Original line number Diff line number Diff line
@@ -2197,7 +2197,7 @@ static int __ip_mc_join_group(struct sock *sk, struct ip_mreqn *imr, 
		count++;

	}

	err = -ENOBUFS;

	if (count >= net->ipv4.sysctl_igmp_max_memberships)

	if (count >= READ_ONCE(net->ipv4.sysctl_igmp_max_memberships))

		goto done;

	iml = sock_kmalloc(sk, sizeof(*iml), GFP_KERNEL);

	if (!iml)