Commit 6302aead authored by Colin Ian King's avatar Colin Ian King Committed by Alex Deucher
Browse files

drm/amd/display: fix the return of the uninitialized value in ret 



Currently if stream->signal is neither SIGNAL_TYPE_DISPLAY_PORT_MST or
SIGNAL_TYPE_DISPLAY_PORT then variable ret is uninitialized and this is
checked for > 0 at the end of the function.  Ret should be initialized,
I believe setting it to zero is a correct default.

Addresses-Coverity: ("Uninitialized scalar variable")
Fixes: bd0c064c ("drm/amd/display: Add return code instead of boolean for future use")
Reviewed-by: default avatarHarry Wentland <harry.wentland@amd.com>
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 03e0dbcd

drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c

+1 −1
Original line number Diff line number Diff line
@@ -530,7 +530,7 @@ bool dm_helpers_dp_write_dsc_enable( 
{

	uint8_t enable_dsc = enable ? 1 : 0;

	struct amdgpu_dm_connector *aconnector;

	uint8_t ret;

	uint8_t ret = 0;



	if (!stream)

		return false;