Commit 630211a1 authored by Tom Rix's avatar Tom Rix Committed by Moritz Fischer
Browse files

fpga: fpga-mgr: wrap the write_sg() op 



An FPGA manager should not be required to provide a
write_sg function. Move the op check to the wrapper.
Default to -EOPNOTSUP so its users will fail
gracefully.

[mdf@kernel.org: Reworded first line]
Signed-off-by: default avatarTom Rix <trix@redhat.com>
Signed-off-by: default avatarMoritz Fischer <mdf@kernel.org>
parent 6489d3b0

drivers/fpga/fpga-mgr.c

+9 −1
Original line number Diff line number Diff line
@@ -83,6 +83,14 @@ static inline int fpga_mgr_write_init(struct fpga_manager *mgr, 
	return 0;

}



static inline int fpga_mgr_write_sg(struct fpga_manager *mgr,

				    struct sg_table *sgt)

{

	if (mgr->mops->write_sg)

		return  mgr->mops->write_sg(mgr, sgt);

	return -EOPNOTSUPP;

}



/**

 * fpga_image_info_alloc - Allocate an FPGA image info struct

 * @dev: owning device
@@ -225,7 +233,7 @@ static int fpga_mgr_buf_load_sg(struct fpga_manager *mgr, 
	/* Write the FPGA image to the FPGA. */

	mgr->state = FPGA_MGR_STATE_WRITE;

	if (mgr->mops->write_sg) {

		ret = mgr->mops->write_sg(mgr, sgt);

		ret = fpga_mgr_write_sg(mgr, sgt);

	} else {

		struct sg_mapping_iter miter;