Commit 62fa3ce0 authored by Brian King's avatar Brian King Committed by Martin K. Petersen
Browse files

scsi: ibmvfc: Avoid path failures during live migration 



Fix an issue reported when performing a live migration when multipath is
configured with a short fast fail timeout of 5 seconds and also to have
no_path_retry set to fail. In this scenario, all paths would go into the
devloss state while the ibmvfc driver went through discovery to log back
in. On a loaded system, the discovery might take longer than 5 seconds,
which was resulting in all paths being marked failed, which then resulted
in a read only filesystem.

This patch changes the migration code in ibmvfc to avoid deleting rports at
all in this scenario, so we avoid losing all paths.

Signed-off-by: default avatarBrian King <brking@linux.vnet.ibm.com>
Link: https://lore.kernel.org/r/20221026181356.148517-1-brking@linux.vnet.ibm.com


Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 307539ee

drivers/scsi/ibmvscsi/ibmvfc.c

+11 −3
Original line number Original line Diff line number Diff line
@@ -708,8 +708,13 @@ static void ibmvfc_init_host(struct ibmvfc_host *vhost) 
		memset(vhost->async_crq.msgs.async, 0, PAGE_SIZE);

		memset(vhost->async_crq.msgs.async, 0, PAGE_SIZE);

		vhost->async_crq.cur = 0;

		vhost->async_crq.cur = 0;





		list_for_each_entry(tgt, &vhost->targets, queue)

		list_for_each_entry(tgt, &vhost->targets, queue) {

			if (vhost->client_migrated)

				tgt->need_login = 1;

			else

				ibmvfc_del_tgt(tgt);

				ibmvfc_del_tgt(tgt);

		}



		scsi_block_requests(vhost->host);

		scsi_block_requests(vhost->host);

		ibmvfc_set_host_action(vhost, IBMVFC_HOST_ACTION_INIT);

		ibmvfc_set_host_action(vhost, IBMVFC_HOST_ACTION_INIT);

		vhost->job_step = ibmvfc_npiv_login;

		vhost->job_step = ibmvfc_npiv_login;
@@ -3235,9 +3240,12 @@ static void ibmvfc_handle_crq(struct ibmvfc_crq *crq, struct ibmvfc_host *vhost, 
			/* We need to re-setup the interpartition connection */

			/* We need to re-setup the interpartition connection */

			dev_info(vhost->dev, "Partition migrated, Re-enabling adapter\n");

			dev_info(vhost->dev, "Partition migrated, Re-enabling adapter\n");

			vhost->client_migrated = 1;

			vhost->client_migrated = 1;



			scsi_block_requests(vhost->host);

			ibmvfc_purge_requests(vhost, DID_REQUEUE);

			ibmvfc_purge_requests(vhost, DID_REQUEUE);

			ibmvfc_link_down(vhost, IBMVFC_LINK_DOWN);

			ibmvfc_set_host_state(vhost, IBMVFC_LINK_DOWN);

			ibmvfc_set_host_action(vhost, IBMVFC_HOST_ACTION_REENABLE);

			ibmvfc_set_host_action(vhost, IBMVFC_HOST_ACTION_REENABLE);

			wake_up(&vhost->work_wait_q);

		} else if (crq->format == IBMVFC_PARTNER_FAILED || crq->format == IBMVFC_PARTNER_DEREGISTER) {

		} else if (crq->format == IBMVFC_PARTNER_FAILED || crq->format == IBMVFC_PARTNER_DEREGISTER) {

			dev_err(vhost->dev, "Host partner adapter deregistered or failed (rc=%d)\n", crq->format);

			dev_err(vhost->dev, "Host partner adapter deregistered or failed (rc=%d)\n", crq->format);

			ibmvfc_purge_requests(vhost, DID_ERROR);

			ibmvfc_purge_requests(vhost, DID_ERROR);