Commit 62e5d006 authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Greg Kroah-Hartman
Browse files

misc: microchip: pci1xxxx: Fix a memory leak in the error handling of gp_aux_bus_probe() 



'aux_bus' is freed in the remove function but not in the error handling
path of the probe.

Use devm_kzalloc() to simplify the remove function and fix the leak in the
probe.

Fixes: 393fc2f5 ("misc: microchip: pci1xxxx: load auxiliary bus driver for the PIO function in the multi-function endpoint of pci1xxxx device.")
Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/17e19926669a1654e5f2495bf3b289581183d02e.1663482259.git.christophe.jaillet@wanadoo.fr


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent c8b47475

drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.c

+1 −2
Original line number Diff line number Diff line
@@ -38,7 +38,7 @@ static int gp_aux_bus_probe(struct pci_dev *pdev, const struct pci_device_id *id 
	if (retval)

		return retval;



	aux_bus = kzalloc(sizeof(*aux_bus), GFP_KERNEL);

	aux_bus = devm_kzalloc(&pdev->dev, sizeof(*aux_bus), GFP_KERNEL);

	if (!aux_bus)

		return -ENOMEM;
@@ -138,7 +138,6 @@ static void gp_aux_bus_remove(struct pci_dev *pdev) 
	auxiliary_device_uninit(&aux_bus->aux_device_wrapper[0]->aux_dev);

	auxiliary_device_delete(&aux_bus->aux_device_wrapper[1]->aux_dev);

	auxiliary_device_uninit(&aux_bus->aux_device_wrapper[1]->aux_dev);

	kfree(aux_bus);

}



static const struct pci_device_id pci1xxxx_tbl[] = {