Commit 62af0ee9 authored by Bart Van Assche's avatar Bart Van Assche Committed by Martin K. Petersen
Browse files

scsi: core: Change the type of the second argument of scsi_host_complete_all_commands() 

Allow the compiler to verify the type of the second argument passed to
scsi_host_complete_all_commands().

Link: https://lore.kernel.org/r/20210524025457.11299-4-bvanassche@acm.org


Cc: Hannes Reinecke <hare@suse.com>
Cc: John Garry <john.garry@huawei.com>
Reviewed-by: default avatarHimanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: default avatarBart Van Assche <bvanassche@acm.org>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 149d0e48

drivers/scsi/hosts.c

+5 −3
Original line number Diff line number Diff line
@@ -655,10 +655,11 @@ EXPORT_SYMBOL_GPL(scsi_flush_work); 
static bool complete_all_cmds_iter(struct request *rq, void *data, bool rsvd)

{

	struct scsi_cmnd *scmd = blk_mq_rq_to_pdu(rq);

	int status = *(int *)data;

	enum scsi_host_status status = *(enum scsi_host_status *)data;



	scsi_dma_unmap(scmd);

	scmd->result = status << 16;

	scmd->result = 0;

	set_host_byte(scmd, status);

	scmd->scsi_done(scmd);

	return true;

}
@@ -673,7 +674,8 @@ static bool complete_all_cmds_iter(struct request *rq, void *data, bool rsvd) 
 * caller to ensure that concurrent I/O submission and/or

 * completion is stopped when calling this function.

 */

void scsi_host_complete_all_commands(struct Scsi_Host *shost, int status)

void scsi_host_complete_all_commands(struct Scsi_Host *shost,

				     enum scsi_host_status status)

{

	blk_mq_tagset_busy_iter(&shost->tag_set, complete_all_cmds_iter,

				&status);

include/scsi/scsi_host.h

+1 −1
Original line number Diff line number Diff line
@@ -764,7 +764,7 @@ extern void scsi_host_put(struct Scsi_Host *t); 
extern struct Scsi_Host *scsi_host_lookup(unsigned short);

extern const char *scsi_host_state_name(enum scsi_host_state);

extern void scsi_host_complete_all_commands(struct Scsi_Host *shost,

					    int status);

					    enum scsi_host_status status);



static inline int __must_check scsi_add_host(struct Scsi_Host *host,

					     struct device *dev)