Commit 629715ad authored by Eric W. Biederman's avatar Eric W. Biederman
Browse files

ucounts: Pair inc_rlimit_ucounts with dec_rlimit_ucoutns in commit_creds 

The purpose of inc_rlimit_ucounts and dec_rlimit_ucounts in commit_creds
is to change which rlimit counter is used to track a process when the
credentials changes.

Use the same test for both to guarantee the tracking is correct.

Cc: stable@vger.kernel.org
Fixes: 21d1c5e3 ("Reimplement RLIMIT_NPROC on top of ucounts")
Link: https://lkml.kernel.org/r/87v91us0w4.fsf_-_@disp2133


Tested-by: default avatarYu Zhao <yuzhao@google.com>
Reviewed-by: default avatarAlexey Gladkov <legion@kernel.org>
Signed-off-by: default avatar"Eric W. Biederman" <ebiederm@xmission.com>
parent 15bc01ef

kernel/cred.c

+1 −1
Original line number Diff line number Diff line
@@ -501,7 +501,7 @@ int commit_creds(struct cred *new) 
		inc_rlimit_ucounts(new->ucounts, UCOUNT_RLIMIT_NPROC, 1);

	rcu_assign_pointer(task->real_cred, new);

	rcu_assign_pointer(task->cred, new);

	if (new->user != old->user)

	if (new->user != old->user || new->user_ns != old->user_ns)

		dec_rlimit_ucounts(old->ucounts, UCOUNT_RLIMIT_NPROC, 1);

	alter_cred_subscribers(old, -2);